Skip to content

Add Fedora CI opt-in/opt-out config options to packit-service.yaml#696

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
m-blaha:eln-logdetective-opt-out
Mar 23, 2026
Merged

Add Fedora CI opt-in/opt-out config options to packit-service.yaml#696
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
m-blaha:eln-logdetective-opt-out

Conversation

@m-blaha
Copy link
Member

@m-blaha m-blaha commented Mar 18, 2026

@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 18, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/2f54c3ebedd34abb96f785d86550ac60

✔️ pre-commit SUCCESS in 1m 37s

lbarcziova
lbarcziova reviewed Mar 18, 2026
View reviewed changes
secrets/packit/prod/packit-service.yaml.j2 Outdated
Comment on lines +139 to +140
# Used in opt-in mode (fedora_ci_run_by_default=false)
enabled_projects: []
Copy link
Member

@lbarcziova lbarcziova Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can remove this to be explicit

Copy link
Member Author

@m-blaha m-blaha Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've removed it from production. I also added a comment for each option, just to clarify what they do. Wdyt?

@m-blaha
Add Fedora CI opt-in/opt-out config options to packit-service.yaml
a437877 
Also clarifies the Fedora CI enabled_project comment. Since the Fedora
CI is now on by default in production, the warning wording is a bit
misleading.
@m-blaha m-blaha force-pushed the eln-logdetective-opt-out branch from 132e708 to a437877 Compare March 18, 2026 17:00
@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 18, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/c0a3542a8c914a908281de68d9dffa1f

✔️ pre-commit SUCCESS in 1m 36s

@majamassarini majamassarini mentioned this pull request Mar 20, 2026
Closed
@m-blaha m-blaha added the mergeit Merge via Zuul label Mar 23, 2026
@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 23, 2026

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/78fe5b59700f477eb9bc89cda8fef7d0

✔️ pre-commit SUCCESS in 1m 36s

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 636eb6a into packit:main Mar 23, 2026
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Mar 23, 2026
@m-blaha m-blaha deleted the eln-logdetective-opt-out branch March 23, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

Packit pull requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-blaha @lbarcziova @usercont-release-bot